FWIW Growing up on the farm in Indiana we always used locust fence posts when we were building fence. The reason was they were strong, hard and took many years to rot off. IMO I would think locust would work well in a pond if it is seasoned first as DD1 stated.

[Linked Image]
Be Brave Enough to Suck at Something New!