There are lots of different types of Shiners besides GSH - Emerald Shiners come to mind first.
I think GSH would be real easy to keep in an aquarium, but hard to get to spawn. They need shallow water with aquatic or overhanging terrestrial plants to attach their eggs to. That's on top of whatever temp cycle & diurnal cycle requirements they may have.
I would use the standard 1" of fish per gallon of aquarium rule to determine stocking numbers.
I tried to raise 18 4" golden shiners TWICE in my big aquarium stocked with 7 3-6" CNBG and 24 2-3" FH in it. Both times, all seemed to be going well for about a month after adding. Then BAM! ALL 18 died within 3 days of each other. No other fish showed any sign of stress with no changes in good water conditions. Never did figure out what went wrong.
