So the ground table is just starting to fill up and water is just starting to enter the pond.
The water is percolating out of the ground at 24" below full pool, i'm currently down 36" All of a sudden I had an A-HA moment "That's where the leak is" I said to myself.....when the groundwater level drops the water flows right back in, that explains everything

So the question is where do i fix it and whats the best method

My idea is to trench down just above high point water level and pack the trench with clay
im almost positive this is the last problem I want to make sure I do it right
any ideas?

I have ZERO experience with fixing this problem. However, I question whether a spring that originates at a higher level would have enough pressure to overcome the attempted fix. I know very little about flowing springs.

Yeah, not an ideal place to have a spring. You could try cramming a pipe in the hole and see where the water rises to. That will let you know the water level would be before not acting as an inlet any more.

If I were to guess, the spring is related to the small dry creek bed above. It may be an old buried creek bed of gravel the water runs through, so it may have to back up quite a way to reach your full pool, and by then water may be finding a new route somewhere else.

I would do as you are suggesting: Dig a trench just above the water line in hopes of intercepting the flow of water and dam it off with clay, liner, or both. Hopefully the water from the spring will back up, and eventually water will overflow your plug above the full pool line. The risk is not finding the spring where you expect.

Can you hand shovel some of the spring to get an idea of direction of flow?

To add to LS post, I would put a pipe hose down into that spring spot before you pack it. If the pressure does get high enough form the water backing up, it should flow out and fill you pond from above the surface. Can never hurt to have the extra water if it does.

https://youtu.be/9iYuXFVErgQ

Some may think this is the most boring video but I find them interesting Lol

So here's an other video
When we get a lot of rain the ground water builds up so much it's starts running on the surface
It first comes up in the pond then it comes Out of the ground by the pipe and flows down the gully I cut in
Then when there's a lot of rain it gushes out of the pipe that comes from the other side of the road

I'll post some more pictures tonight
One thing I did (and I had the right idea but I did it in the wrong place) was, I dug a trench to stop underground stream but I did it right in front of the spring you see in the first video
(Deeper in the pond)
I dug down 15'

Fish that's not a bad idea
It would be nice to backup the water flow underground and have some sort of pipe realving the build up of water pressure